chore: develop deprecation and related changes #6668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 502f311 in 41 seconds
More details
- Looked at
237lines of code in14files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. CONTRIBUTING.md:339
- Draft comment:
Update the contribution guidelines to reflect that contributions should be made to the 'main' branch instead of the 'develop' branch. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_VQvSWGomEkiMSyzu
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Signed-off-by: Prashant Shahi <[email protected]>
grandwizard28
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Important
Deprecate
developbranch in favor ofmainacross workflows, scripts, and documentation.developbranch frombuild.yaml,push.yaml,sonar.yml, andjest-coverage-changes.yml.docs.yml,e2e-k3s.yaml,staging-deployment.yaml, andtesting-deployment.yamlto trigger onmaininstead ofdevelop.hotrod-install.shandhotrod-delete.shto usemainbranch.developbranch check infrontend/.husky/commit-msg.CONTRIBUTING.mdanddeploy/README.mdto referencemainbranch instead ofdevelop.This description was created by
for 502f311. It will automatically update as commits are pushed.